Fixes .net10 msbuild compatibility issue (#1716) #1738
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm unsure if setting Edit: Perhaps changing the condition for .net8 and 9 to |
Collaborator
|
Version 17.14.28 should support .NET 10 https://www.nuget.org/packages/Microsoft.Build/17.14.28#supportedframeworks-body-tab I guess this should work: @phillijw Could you please elaborate why do you think it will fix the issues if the lower version supports .NET 10? |
Author
I think the change you suggested is the correct fix after doing some more digging. I will push that change to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The msbuild version in .net10 has breaking changes from previous versions. This conditionally selects the appropriate version depending on the target framework during build.