Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested types inside of the <Module> type #111435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow nested types inside of the <Module> type #111435

wants to merge 1 commit into from
+6 −0

Conversation

davidwrighton
Copy link
Member

  • This isn't disallowed by spec, although ilasm and ildasm cannot handle these cases, so we can't easily build a regression test
  • Simply skip adding the type to the available class hash.

Fix #111164

@davidwrighton
Allow nested types inside of the <Module> type
0221aff 
- This isn't disallowed by spec, although ilasm and ildasm cannot handle these cases
- Simply skip adding the type to the available class hash.

Fix dotnet#111164
@davidwrighton
Copy link
Member Author

@steveisok could you assign somebody to review this?

@steveisok steveisok requested a review from a team January 15, 2025 03:12
This was referenced Jan 15, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@davidwrighton davidwrighton

Labels
area-TypeSystem-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BadImageFormatException on startup after adding a nested type to <Module> in .NET 9
2 participants
@davidwrighton @jkotas