Clean up our runtime-deps packages and enable ARM64 Debs #112671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the special Mariner package copies
…ckages for any more. These distros publish .NET RPMs themselves.
…the deb package. We don't publish packages for Ubuntu any more
jkoritzinsky
requested review from
leecow,
richlander,
NikolaMilosavljevic and
Copilot
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (12)
- eng/Signing.props: Language not supported
- src/installer/pkg/sfx/Directory.Build.props: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-centos.9.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-cm.2.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-debian.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-fedora.27.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-opensuse.15.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-opensuse.42.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-oraclelinux.8.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-rhel.8.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-sles.12.proj: Language not supported
- src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-sles.15.proj: Language not supported
This was referenced Feb 19, 2025
Open
|
FYI @vcsjones -- Look like OpenSSL 1.1.1 will be our min-bar dependency for .NET 10. I think you said that this version would be a simplifiying, as opposed to earlier versions. Note that we cannot drop OpenSSL 1.x until Ubuntu 22.04 plays the role that 18.04 does now for us. |
src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-debian.proj
Outdated
Show resolved
Hide resolved
…de the version that we know any debian distro has.
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Feb 19, 2025
As ICU approaches version 80, we need to consider what to do about our ICU version ranges. Our system currently supports a min version of 50 and a max of "min + 30", so 80. ICU60 is the version that shipped with Ubuntu 18.04, which is the distro that we base our libc version on. For Alpine, the version of ICU in the distro we base our libc on (3.17) ships with ICU 72. I recommend that we bump our min to ICU60, which will by our current rules bump our max to ICU90, which will give us more runway. I'd recommend holding off on merging this until dotnet#112671 is merged, as that PR changes our deps packages to better describe scenarios where we actually ship packages today.
NikolaMilosavljevic
approved these changes
Feb 20, 2025
|
@leecow does this require any changes in release infra? |
|
We'll need to make updates when we want to start shipping debs for ARM and if there are any file name changes for the updated files. |
jkoritzinsky
added a commit
that referenced
this pull request
Feb 20, 2025
* Bump the minimum ICU version to 60 As ICU approaches version 80, we need to consider what to do about our ICU version ranges. Our system currently supports a min version of 50 and a max of "min + 30", so 80. ICU60 is the version that shipped with Ubuntu 18.04, which is the distro that we base our libc version on. For Alpine, the version of ICU in the distro we base our libc on (3.17) ships with ICU 72. I recommend that we bump our min to ICU60, which will by our current rules bump our max to ICU90, which will give us more runway. I'd recommend holding off on merging this until #112671 is merged, as that PR changes our deps packages to better describe scenarios where we actually ship packages today. * Remove old optional definition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our runtime-deps packages have not kept up with the various changes in our support matrix for various Linux distros and packages. This PR makes the following adjustments to our package definitions to match our support matrix:
Also, this PR enables building ARM64 deb packages.
It also ensures that the AzureLinux 3 deps RPM is signed with the correct key from the start.
Contributes to #104013
Fixes #3298
Technically fixes #3768 as well
As a side note, this PR removes the last dependency we had on OpenSSL 1.0 (the old OpenSuSE 42 package). So after this PR goes in, we can remove OpenSSL 1.0 support from the product.