Skip to content

Remove setting $ORIGIN/netcoredeps rpath #114512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

elinor-fung
Copy link
Member

The original use case for setting the RPATH was self-contained Linux apps.

Some time between .NET 6 and .NET 8, we started using a newer linker, such that this setting sets RUNPATH instead of RPATH. This meant it only applied to the host executable, not the runtime libraries (like coreclr).

Per #114393 (comment), the netcoredeps behaviour was from a time when our dependencies were more complicated and even its intended use case has no support story.

See

cc @am11 @jkotas @dotnet/interop-contrib

@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 23:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/native/corehost/apphost/standalone/CMakeLists.txt: Language not supported
  • src/native/corehost/apphost/static/CMakeLists.txt: Language not supported

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants