Again adjust for culture name normalization in AssemblyNameInfoFuzzer #114531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MihuBot fuzz AssemblyNameInfo |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/libraries/System.Reflection.Metadata/tests/Metadata/AssemblyNameInfoTests.cs:111
- [nitpick] Consider adding additional test cases with more complex culture names (e.g., multiple '-' characters) to ensure the normalization behavior is robust for various inputs.
public static IEnumerable<object[]> CultureNameGetLoweredByToAssemblyName_Arguments()
|
|
||
| string lowerCase = fromTryParse.CultureName.ToLower(); | ||
| if (lowerCase != "c") | ||
| { | ||
| Assert.Equal(lowerCase, fromParse.ToAssemblyName().CultureName); | ||
| Assert.Equal(lowerCase, fromParse.ToAssemblyName().CultureName!.ToLower()); |
There was a problem hiding this comment.
The simplified normalization by lower-casing the entire culture name is clear in the test; consider verifying that this approach continues to cover all relevant scenarios with culture names that might have more than one '-' character.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
MihaZupan
approved these changes
Apr 11, 2025
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#114231 was not enough, as only characters before
-get lowered:runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs
Line 743 in 778427c
The issue was not discovered by our public fuzzing infra in #114328 (comment)