ILLink : Test API expsure #114567
Open
ILLink : Test API expsure #114567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-expose `ReconstructedFullTypeName`. We rely on this in our test framework Expose `VerifyILOfOtherAssemblies`. This causes us problems for our tests that verify the old mono BCL. There's a goofy circular reference with Mono.Security.dll and System.dll which results in references to System.dll with two different PublicKeyTokens. Exposing this method let's us disable this asserting behavior for our old mono tests
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
linkable-framework
|
@sbomer Please take a look |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/tools/illink/test/Mono.Linker.Tests/TestCases/TestCase.cs:27
- Since the API is now public, consider updating the inline comment to more formally document the rationale behind the name reconstruction, instead of referring to it as 'a little hacky'.
ReconstructedFullTypeName = "$...{sourceFile.FileNameWithoutExtension}";
src/tools/illink/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
Show resolved
Hide resolved
This was referenced Apr 12, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-expose
ReconstructedFullTypeName. We rely on this in our test frameworkExpose
VerifyILOfOtherAssemblies. This causes us problems for our tests that verify the old mono BCL. There's a goofy circular reference with Mono.Security.dll and System.dll which results in references to System.dll with two different PublicKeyTokens. Exposing this method let's us disable this asserting behavior for our old mono tests