[Android] Reenable SocketsHttpHandlerTest.LargeHeaders_TrickledOverTime_ProcessedEfficiently on 64-bit Android #117710
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-extra-platrofms |
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables a previously disabled test on 64-bit Android platforms while keeping it disabled on 32-bit Android where it causes out-of-memory issues. The change replaces a blanket test exclusion for all Android platforms with a more targeted approach that only skips the test on 32-bit Android architectures.
- Replaced
[ActiveIssue]attribute with runtime platform detection - Added conditional skip logic for 32-bit Android processes only
- Changed from
[Theory]to[ConditionalTheory]to support runtime test skipping
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Outdated
Show resolved
Hide resolved
|
No pipelines are associated with this pull request. |
…pHandlerTest.cs Co-authored-by: Copilot <[email protected]>
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Jul 16, 2025
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 16, 2025
Open
…pHandlerTest.cs Co-authored-by: Alexander Köplinger <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77474
The test is known to run out of memory on 32-bit Android. We should still run the test on 64-bit Android which most commonly used by end customers.