Skip to content

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Sep 2, 2025

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP
Copy link
Member Author

ManickaP commented Sep 3, 2025

This didn't work:

MsQuic not supported and using 'unknown' .
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 3, Errors: 0, Failed: 0, Skipped: 0, Time: 0.430s

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-119273-merge-a6f9cd7cc4be494e96/System.Net.Quic.Functional.Tests/1/console.7c999cf3.log?helixlogtype=result

@liveans
Copy link
Member

liveans commented Sep 3, 2025

This didn't work:

MsQuic not supported and using 'unknown' .
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 3, Errors: 0, Failed: 0, Skipped: 0, Time: 0.430s

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-119273-merge-a6f9cd7cc4be494e96/System.Net.Quic.Functional.Tests/1/console.7c999cf3.log?helixlogtype=result

I'll look at this to figure out what's needed for the package to be installed.

@ManickaP
Copy link
Member Author

ManickaP commented Sep 3, 2025

This seems to be working: https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-119273-merge-eeece5df5bbc4ba993/System.Net.Quic.Functional.Tests/1/console.15f7eccb.log?helixlogtype=result

Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 138 of 153 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on [12 threads], stop on fail = off)
MsQuic supported and using 'libmsquic.dylib 2.5.5.0 (b3945bb0c9e44463c93dac13e40975a7c3a526ca)' (OpenSSL).
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
MsQuic Counters:
    CONN_CREATED 1608
    CONN_HANDSHAKE_FAIL 25
    CONN_APP_REJECT 8
    CONN_LOAD_REJECT 0

Unobserved exceptions of 0 different types: 

  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 428, Errors: 0, Failed: 0, Skipped: 1, Time: 119.672s

But there's a problem with AOT build, hopefully addressed in: liveans/msquic-nuget#1

@ManickaP ManickaP marked this pull request as ready for review September 8, 2025 07:53
@Copilot Copilot AI review requested due to automatic review settings September 8, 2025 07:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dual package consumption system for MsQuic on Windows and macOS, simplifying the package management by using dedicated packages for each platform. It eliminates the transport package option previously used for testing pre-released versions and instead uses the official Microsoft.Native.Quic.MsQuic.Schannel package for Windows and the manually built MsQuic.Native package for macOS.

  • Removes UseQuicTransportPackage property and all transport package references
  • Updates macOS to use MsQuic.Native version 2.5.6 instead of the transport package
  • Updates documentation to reflect current build processes and removes obsolete transport package information

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/libraries/System.Net.Quic/src/System.Net.Quic.csproj Removes transport package logic and updates macOS to use MsQuic.Native package
src/libraries/System.Net.Quic/readme.md Updates documentation with current Linux build process and removes Windows transport package references
eng/Versions.props Removes unused SystemNetMsQuicTransportVersion property

@ManickaP
Copy link
Member Author

ManickaP commented Sep 8, 2025

It works, see:

E.g.:

Console log: 'System.Net.Quic.Functional.Tests' from job dd7a04bb-1d99-4d06-ba88-17df5c17307e workitem 8fe74b08-d6cd-4bde-9c24-9119f5b7413a (osx.1200.amd64.open) executed on machine dci-mac-build-130 running macOS-12.7.2
...
/private/tmp/helix/working/B77B09A6/w/B8B809B0/e /private/tmp/helix/working/B77B09A6/w/B8B809B0/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 138 of 153 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on [4 threads], stop on fail = off)
MsQuic supported and using 'libmsquic.dylib 2.5.5.0 (b3945bb0c9e44463c93dac13e40975a7c3a526ca)' (OpenSSL).
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
MsQuic Counters:
    CONN_CREATED 1608
    CONN_HANDSHAKE_FAIL 25
    CONN_APP_REJECT 8
    CONN_LOAD_REJECT 0

Unobserved exceptions of 0 different types: 

  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 428, Errors: 0, Failed: 0, Skipped: 1, Time: 134.143s
/private/tmp/helix/working/B77B09A6/w/B8B809B0/e
----- end Fri Sep 5 10:07:44 EDT 2025 ----- exit code 0 ----------------------------------------------------------

@dotnet/ncl

@ManickaP ManickaP requested review from liveans and a team September 8, 2025 07:55
Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ManickaP ManickaP merged commit dc5ea71 into dotnet:main Sep 8, 2025
161 checks passed
@ManickaP ManickaP deleted the osx-msquic branch September 8, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants