-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[QUIC] Consume manually built MsQuic package for OSX #119273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/ncl |
This didn't work:
|
I'll look at this to figure out what's needed for the package to be installed. |
This seems to be working: https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-119273-merge-eeece5df5bbc4ba993/System.Net.Quic.Functional.Tests/1/console.15f7eccb.log?helixlogtype=result
But there's a problem with AOT build, hopefully addressed in: liveans/msquic-nuget#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the dual package consumption system for MsQuic on Windows and macOS, simplifying the package management by using dedicated packages for each platform. It eliminates the transport package option previously used for testing pre-released versions and instead uses the official Microsoft.Native.Quic.MsQuic.Schannel package for Windows and the manually built MsQuic.Native package for macOS.
- Removes
UseQuicTransportPackage
property and all transport package references - Updates macOS to use
MsQuic.Native
version 2.5.6 instead of the transport package - Updates documentation to reflect current build processes and removes obsolete transport package information
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/libraries/System.Net.Quic/src/System.Net.Quic.csproj | Removes transport package logic and updates macOS to use MsQuic.Native package |
src/libraries/System.Net.Quic/readme.md | Updates documentation with current Linux build process and removes Windows transport package references |
eng/Versions.props | Removes unused SystemNetMsQuicTransportVersion property |
It works, see:
E.g.:
@dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
cc @liveans