Skip to content

[QUIC] Consume main MsQuic in stress #119278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2025
Merged

[QUIC] Consume main MsQuic in stress #119278

merged 2 commits into from
Sep 3, 2025

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Sep 2, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 16:32
@ManickaP
Copy link
Member Author

ManickaP commented Sep 2, 2025

/azp run runtime-libraries stress-http

Copilot
Copilot AI reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MsQuic dependency in the HTTP stress tests to use the main branch instead of the pinned v2.4.4 version. This change allows the stress tests to consume the latest MsQuic developments and improvements.

Key changes:

  • Updates MsQuic branch from v2.4.4 to main for stress testing

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP
Copy link
Member Author

ManickaP commented Sep 2, 2025

/azp run runtime-libraries stress-http

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

ManickaP commented Sep 3, 2025

/azp run runtime-libraries stress-http

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

ManickaP commented Sep 3, 2025

/azp run runtime-libraries stress-http

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

ManickaP commented Sep 3, 2025

Apart from what I'm trying to fix in #119274 this is working:
https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/build/builds/1137987/logs/15

server_1  |   MsQuic Version: libmsquic.so 2.6.0.0 (af6bb2b51a1ad7ece794fc66ff5d5176f4a908df)
...
client_1  |   MsQuic Version: libmsquic.so 2.6.0.0 (af6bb2b51a1ad7ece794fc66ff5d5176f4a908df)
...
client_1  | 	    TOTAL                     Success: 608,192	Canceled: 45,606	Fail: 0

@dotnet/ncl can someone please review?

@ManickaP ManickaP requested a review from a team September 3, 2025 08:56
@ManickaP ManickaP merged commit c6566fb into dotnet:main Sep 3, 2025
89 of 91 checks passed
@ManickaP ManickaP deleted the stress-msquic branch September 3, 2025 10:56
filipnavara pushed a commit to filipnavara/runtime that referenced this pull request Sep 5, 2025
@ManickaP @filipnavara
[QUIC] Consume main MsQuic in stress (dotnet#119278)
0694473 
* Consume main MsQuic in stress

* Fix msquic build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@CarnaViire CarnaViire CarnaViire approved these changes

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManickaP @CarnaViire @MihaZupan