[WASM] Build the time zone data for WASM as part of libs.native
#119288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
changed the title
libs.native
dotnet-policy-service
bot
added
the
community-contribution
SingleAccretion
force-pushed
the
TimeZoneBuild
branch
from
3fc56d5 to
221907f
Compare
Open
3 tasks
SingleAccretion
force-pushed
the
TimeZoneBuild
branch
3 times, most recently
from
6ed9563 to
acc3fcf
Compare
|
Tagging subscribers to 'arch-wasm': @lewing |
SingleAccretion
force-pushed
the
TimeZoneBuild
branch
7 times, most recently
from
231e15a to
df9ff46
Compare
pavelsavara
reviewed
Sep 4, 2025
SingleAccretion
commented
Sep 4, 2025
pavelsavara
reviewed
Sep 4, 2025
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Allows: dotnet build /t:Test System.Runtime.InvariantTimezone.Tests.csproj /p:TargetOS=browser /p:TargetArchitecture=wasm /p:JSEngine=NodeJS
This simplifies the WASM build, making this data just another static library. We produce two flavors of it: full and disabled, the latter to support the invariant timezone switch.
SingleAccretion
force-pushed
the
TimeZoneBuild
branch
from
df9ff46 to
58eb7f1
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
reviewed
Sep 5, 2025
SingleAccretion
requested review from
maraf,
akoeplinger and
lewing
as code owners
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
approved these changes
Sep 5, 2025
akoeplinger
reviewed
Sep 5, 2025
maraf
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the WASM build, making this data just another static library. We produce two flavors of it: full and disabled, the latter to support the invariant timezone switch. The static library itself uses some inline assembly to embed the data, but once we do the next EMSDK bump, we can rewrite it to use C23's
#embed(the WASI SDK clang already supports this feature).This is a port, though a bit amended and refactored, of a downstream implementation of the same idea (you can see the original code in the first commit).