Remove unused suppressions for System.Linq.Expressions

[ericstj]

fixes #89206

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

fixes #89206

Author:	ericstj
Assignees:	ericstj
Labels:	area-Infrastructure-libraries, source-build
Milestone:	-

[carlossanlop]

Approving to unblock.

Two questions for my own education:

• What specific change in PR https://github.com/dotnet/runtime/pull/88723/files caused the suppresion errors to start showing up and why?
• Why didn't the CI in that PR show the errors? https://github.com/dotnet/runtime/pull/88723/checks?check_run_id=15146702721

[mthalman]

Approving to unblock.

Two questions for my own education:

• What specific change in PR https://github.com/dotnet/runtime/pull/88723/files caused the suppresion errors to start showing up and why?
• Why didn't the CI in that PR show the errors? https://github.com/dotnet/runtime/pull/88723/checks?check_run_id=15146702721

The error only shows up when using the 8.0 Preview 7 SDK to build. This repo isn't using that.

[ericstj]

Correct, we cannot use the Preview7 SDK yet because it is not done. We cannot use the nightly build of APICompat because it depends on preview7 API that was added to runtime. So we're in a situation for a few weeks where we'll not have protection for these.

@mthalman another option here would be to just disable the consistency check until we can turn it on in dotnet/runtime. To do that you can set ApiCompatPermitUnnecessarySuppressions to true.

[ivanpovazan]

Regarding:

• What specific change in PR https://github.com/dotnet/runtime/pull/88723/files caused the suppresion errors to start showing up and why?

Before the change, we were building/shipping System.Linq.Expressions.dll differently for iOS-like platforms (ios/tvos/maccatalyst) so the suppressions were put into place to accomodate this (note the extra entries which had platform name in the paths in Right element)

• Why didn't the CI in that PR show the errors? https://github.com/dotnet/runtime/pull/88723/checks?check_run_id=15146702721

I had the same question, so thanks @mthalman @ericstj for the clarification in your comments.

If I understand correctly, I should have had built the runtime with /p:ApiCompatGenerateSuppressionFile=true to update the suppressions and made it part of my PR.

[ericstj]

I should have had built the runtime with /p:ApiCompatGenerateSuppressionFile=true

You could have, but I honestly wouldn't expect you to realize that. Once we can update to the Preview7 SDK it will be obvious, and hopefully the steps you need to take will be apparent in the error message.

Also - you don't need to do it for the whole repo - you could simply do this when building a single src csproj.