Update WCF sample Compression Encoder code to conditionally support NET framework / Core #6282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconnew
reviewed
Oct 31, 2023
| @@ -20,68 +19,73 @@ static class GZipMessageEncodingPolicyConstants | |||
| } | |||
|
|
|||
| //This is the binding element that, when plugged into a custom binding, will enable the GZip encoder | |||
| #if NET462_OR_GREATER | |||
| public sealed class GZipMessageEncodingBindingElement | |||
There was a problem hiding this comment.
Can simplify with a single #if block
public sealed class GZipMessageEncodingBindingElement
: MessageEncodingBindingElement //BindingElement
#if NET462_OR_GREATER
, IPolicyExportExtension
#endif…NET framework / Core
afifi-ins
force-pushed
the
WcfSamplesUpgrade/CompressionMessageEncoder
branch
from
213e27b to
3c9039b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.