Add extra properties for test results in dotnet test #44109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-DotNet Test
untriaged
…results-in-dotnet-test
…ra-properties-for-test-results-in-dotnet-test
…dotnet-test' of https://github.com/dotnet/sdk into dev/mabdullah/add-extra-properties-for-test-results-in-dotnet-test
nohwnd
reviewed
Oct 11, 2024
src/Cli/dotnet/commands/dotnet-test/IPC/Models/TestResultMessages.cs
Outdated
Show resolved
Hide resolved
nohwnd
approved these changes
Oct 11, 2024
|
This PR requires this change on testfx to be merged: https://github.com/microsoft/testfx/pull/3932/files |
nohwnd
approved these changes
Oct 11, 2024
mariam-abdulla
deleted the
dev/mabdullah/add-extra-properties-for-test-results-in-dotnet-test
branch
|
Relates to #45927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the test result messaging system, primarily focusing on adding new fields to test result messages and updating related serializers and handlers. The most important changes include extending the
SuccessfulTestResultMessageandFailedTestResultMessagerecords, updating field IDs, and modifying the serializers to handle the new fields.Enhancements to Test Result Messages:
src/Cli/dotnet/commands/dotnet-test/IPC/Models/TestResultMessages.cs: AddedDuration,StandardOutput, andErrorOutputfields toSuccessfulTestResultMessageandFailedTestResultMessagerecords.Updates to Field IDs:
src/Cli/dotnet/commands/dotnet-test/IPC/ObjectFieldIds.cs: Updated field IDs to includeDuration,StandardOutput, andErrorOutputfor bothSuccessfulTestResultMessageandFailedTestResultMessage.Serializer Modifications:
src/Cli/dotnet/commands/dotnet-test/IPC/Serializers/BaseSerializer.cs: Added a new method to writelong?values to the stream.src/Cli/dotnet/commands/dotnet-test/IPC/Serializers/TestResultMessagesSerializer.cs: Updated the serializer to handle the new fields (Duration,StandardOutput,ErrorOutput) for both successful and failed test messages.Additional Changes:
src/Cli/dotnet/commands/dotnet-test/Models.cs: Added new fields to theSuccessfulTestResultandFailedTestResultrecords to match the changes inTestResultMessages.src/Cli/dotnet/commands/dotnet-test/TestApplication.cs: Updated theOnTestResultMessagesmethod to handle the new fields in the test result messages.