Skip to content

Comments

[release/9.0.2xx] Split GivenThatWeWantToRunILLink test class into multiple so Helix can run them separately#45056

Merged
joeloff merged 1 commit intorelease/9.0.2xxfrom
backport/pr-44973-to-release/9.0.2xx
Dec 2, 2024
Merged

[release/9.0.2xx] Split GivenThatWeWantToRunILLink test class into multiple so Helix can run them separately#45056
joeloff merged 1 commit intorelease/9.0.2xxfrom
backport/pr-44973-to-release/9.0.2xx

Conversation

@github-actions
Copy link
Contributor

Backport of #44973 to release/9.0.2xx

/cc @joeloff @akoeplinger

@github-actions github-actions bot requested a review from a team as a code owner November 23, 2024 00:52
@ghost ghost added Area-ILLink untriaged Request triage from a team member labels Nov 23, 2024
@joeloff
Copy link
Member

joeloff commented Nov 23, 2024

Hmm, looks like we'll need to split off more tests based off the logs

@akoeplinger
Copy link
Member

not really, the log says

[Long Running Test] 'Microsoft.NET.Build.Tests.GivenThatWeWantToVerifyProjectReferenceCompat.Project_reference_compat', Elapsed: 00:59:49

so this one test took an hour i.e. it just hung.

@joeloff
Copy link
Member

joeloff commented Nov 24, 2024

not really, the log says

[Long Running Test] 'Microsoft.NET.Build.Tests.GivenThatWeWantToVerifyProjectReferenceCompat.Project_reference_compat', Elapsed: 00:59:49

so this one test took an hour i.e. it just hung.

I think it's just a really long running test. It tests compat across net45, 46 and every netstandard version from 1.0 through 2.0

@akoeplinger
Copy link
Member

the test normally takes just a couple minutes for all combinations, I've retried the build
image

@RikkiGibson
Copy link
Member

@joeloff is this ready to merge?

@joeloff
Copy link
Member

joeloff commented Dec 2, 2024

yeah, this was just a straight backport, but some branches are being locked for upcoming servicing builds. Let me double check to confirm

@joeloff joeloff merged commit 3090832 into release/9.0.2xx Dec 2, 2024
@joeloff joeloff deleted the backport/pr-44973-to-release/9.0.2xx branch December 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-ILLink untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants