sln-add: Remove default values #45940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CLI
untriaged
|
Also up for discussion: The use of |
edvilme
changed the title
2 tasks
MiYanni
reviewed
Jan 14, 2025
3 tasks
|
hide the whilespace to see the change https://github.com/dotnet/sdk/pull/45940/files?w=1. it's moving configs to the sln only block |
It adds those configurations only for .sln files for backwards compatibility (not breaking any sln files). However, I do think the default configurations/platforms should maybe be reviewed (i.e., does it make sense to have them hardcoded?) :) |
edvilme
changed the title
|
since its inception, the sln-add command has always strived to match the behavior of Visual Studio |
edvilme
force-pushed
the
edvilme-slnx-add-defaults
branch
from
73322e9 to
63a5e05
Compare
MiYanni
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility and to avoid breaking changes, default configurations and platforms were kept when moving to vs-solutionpersistence. This is irrelevant to add by default to .slnx files (i.e., doesn't break anything and might be redundant)