--interactive should actually default to true in user-facing situations. #48353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CLI
untriaged
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Cli/dotnet/CommonOptions.cs:135
- The inline comment does not reflect the new logic of defaulting interactive mode to true when not running in a CI/redirected environment. Consider updating the comment to accurately describe the behavior.
// this default is called when no tokens/options are passed on the CLI args
This was referenced Apr 10, 2025
baronfel
force-pushed
the
actually-set-interactive-to-true
branch
from
741e66a to
e7c60f3
Compare
baronfel
force-pushed
the
actually-set-interactive-to-true
branch
3 times, most recently
from
6deee76 to
6d73ffa
Compare
baronfel
force-pushed
the
actually-set-interactive-to-true
branch
from
6d73ffa to
39c3d8b
Compare
MiYanni
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this is embarrassing but when I did the
--interactivedefaulting I defaulted it to the wrong way around. Thankfully because today users have to pass--interactiveto get the benefits there wasn't actually a regression.I've fixed the conditional and updated the test baselines - the main changes here are that all of our CI tests have the
falsedefault because it's either a CI/CD system environment or the test is running redirected - so we really only have local testing to prove that this works: