Allow sdk binary in the VMR #48382
Merged
Allow sdk binary in the VMR #48382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/SourceBuild/content/eng/allowed-vmr-binaries.txt:121
- The new allowed binary entry now references a single file without a wildcard pattern and uses a different directory structure compared to the removed entry. Please confirm that this change is intended and that only this specific binary is meant to be allowed; if multiple files should be permitted, consider using a wildcard pattern.
src/sdk/test/dotnet.Tests/ShellShimTests/WpfBinaryTestAssets/testwpf.dll
akoeplinger
approved these changes
Apr 11, 2025
Co-authored-by: Michael Simons <[email protected]>
mthalman
approved these changes
Apr 14, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#5039