Skip to content

Remove extra newline from APIDiff TOC #49794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jul 15, 2025

Fixes #49793

Each link is already added with a trailing newline:

tableOfContents.AppendLine($"* [{assemblyName}]({fileName})");

Adding another new-line makes an empty line at the end of the file that's triggering the linter. Remove this.

@ericstj ericstj requested review from tarekgh and Copilot July 15, 2025 21:02
@ericstj ericstj requested a review from a team as a code owner July 15, 2025 21:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unnecessary blank line appended to the generated API diff table of contents, which was triggering the linter for trailing empty lines.

  • Eliminates the extra AppendLine() call so each entry’s existing newline is sufficient.

@tarekgh
Copy link
Member

tarekgh commented Jul 16, 2025

@ericstj ericstj enabled auto-merge (squash) July 16, 2025 15:47
@ericstj ericstj merged commit b9b384c into main Jul 16, 2025
27 checks passed
@ericstj ericstj deleted the ericstj-apidiff-toc-newline branch July 16, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Diff summary markdown ends with 2 blank lines instead of 1
2 participants