File-based apps: consider args in simple csc optimization #50779
+53
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where file-based C# apps were not properly passing command-line arguments when using the CSC optimization path. The PR ensures that when dotnet run uses the direct CSC compilation approach for file-based apps, the application arguments are correctly forwarded to the executed program.
- Modifies the
CreateCommandForCscBuiltProgrammethod to accept and properly escape application arguments - Updates the method call site to pass the
ApplicationArgsparameter - Adds comprehensive test coverage for the CSC-only path with arguments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Run/RunCommand.cs | Updates CSC optimization path to properly handle application arguments |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds test cases to verify argument passing works correctly in CSC-only scenarios |
RikkiGibson
approved these changes
Sep 12, 2025
MiYanni
approved these changes
Sep 15, 2025
|
@333fred for a review of a simple change, thanks |
333fred
reviewed
Sep 17, 2025
| var programPath = Path.Join(testInstance.Path, "Program.cs"); | ||
|
|
||
| var code = $""" | ||
| #:property Configuration=Release |
There was a problem hiding this comment.
What's the purpose of this flag in this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50778.