Handle empty string returned from Environment.GetFolderPath
#51854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds defensive error handling for a rare edge case where Environment.GetFolderPath or Path.GetTempPath() returns an empty string, preventing potential issues downstream when attempting to construct temporary file paths for file-based app artifacts.
Key Changes
- Added a null/empty string check after obtaining the temporary directory path
- Throws an
InvalidOperationExceptionwith a descriptive message if the path is empty - Protects against potential
ArgumentExceptionor unexpected behavior when passing empty paths toPath.Join
| </data> | ||
| </root> | ||
| <data name="EmptyTempPath" xml:space="preserve"> | ||
| <value>Unable to determine a temporary directory path. Consider configuring the TEMP environment variable on Windows or local app data folder on Unix.</value> |
Contributor
There was a problem hiding this comment.
Path.GetTempPath on Windows never returns an empty string. If GetTempPathW or GetTempPath2W returns a zero length, it throws instead. So this advice on "configuring the TEMP environment variable on Windows" will not be seen on Windows.
Member
There was a problem hiding this comment.
Might be worth having a unit test with different OSs so that we check this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RikkiGibson has noticed in the documentation of Environment.GetFolderPath that it might return an empty string. So this PR handles that case.