Fix logic bug in file mode calculation in sdk container builds - #55656
Open
lbussell wants to merge 1 commit into
Open
Fix logic bug in file mode calculation in sdk container builds#55656lbussell wants to merge 1 commit into
lbussell wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lbussell
enabled auto-merge (squash)
August 6, 2026 22:30
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Unix file permission classification when generating container layers so non-executable files are not incorrectly marked as executable (and thus not always emitted as 0755).
Changes:
- Corrects the execute-bit detection logic in
Layertar entry creation by using a bitwise AND rather than OR when checking permissions.
Comment on lines
192
to
+194
| // On Unix, we can determine the x-bit based on the filesystem permission. | ||
| // On Windows, we use executable permissions for all entries. | ||
| return (OperatingSystem.IsWindows() || ((file.UnixFileMode | UnixFileMode.UserExecute) != 0)) ? executeMode : nonExecuteMode; | ||
| return (OperatingSystem.IsWindows() || ((file.UnixFileMode & UnixFileMode.UserExecute) != 0)) ? executeMode : nonExecuteMode; |
| // On Unix, we can determine the x-bit based on the filesystem permission. | ||
| // On Windows, we use executable permissions for all entries. | ||
| return (OperatingSystem.IsWindows() || ((file.UnixFileMode | UnixFileMode.UserExecute) != 0)) ? executeMode : nonExecuteMode; | ||
| return (OperatingSystem.IsWindows() || ((file.UnixFileMode & UnixFileMode.UserExecute) != 0)) ? executeMode : nonExecuteMode; |
Member
There was a problem hiding this comment.
I'm sorry for ruining your 1 character PR but I do think a regression test would be nice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bitwise or here always produced a nonzero value, marking every Unix file as 755 when some should be 644.