This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 520
Add start/stop option to dashboard and command line option to disable auto-start #1495
Open
csteeg
wants to merge
13
commits into
dotnet:main
Choose a base branch
from
csteeg:csteeg/feature/add-startstop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csteeg
changed the title
Csteeg/feature/add startstop
Add start/stop option to dashboard and command line option to disable auto-start
Dec 23, 2022
|
Yes sorry about that, I created my new wishes (there are even more on my current main branch) in one branch hoping that I could do them 1 by 1, but decided to pick the features and create a PR for them separately later. This one now only contains the start/stop feature |
Looks like great feature, |
Merged
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see PR #948 before, but it's kind of the same feature, so this one is also #876
This feature is because our dev-team wanted to have the @dalibormesaric in #948
We have quite a large set up with loads of services in Tye and watching them all can be stressful for the developer's environment. So, we just want to quit the one service you're working on in Tye and use visual studio for that service.
The other scenario is that we quickly want to start just a few services to test or reproduce something without starting the complete environment. Therefore, I placed the buttons on the overview page instead of the service page, and added a command-line option to skip startup for specific projects (eg we have a Microsoft Fhir server project in there taking quite some time and resources). Now I could also say skip "*" so no project starts automatically and just spint up like the 3 services I need atm from the dashboard
This PR also works for docker containers that are running + I chose to reuse the created method to start the services by adding a reference to the method on the service object. This way we don't have to inject the processrunner anywhere.