Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Add start/stop option to dashboard and command line option to disable auto-start #1495

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

csteeg
Copy link
Contributor

@csteeg csteeg commented Dec 23, 2022

I didn't see PR #948 before, but it's kind of the same feature, so this one is also #876

This feature is because our dev-team wanted to have the @dalibormesaric in #948
We have quite a large set up with loads of services in Tye and watching them all can be stressful for the developer's environment. So, we just want to quit the one service you're working on in Tye and use visual studio for that service.

The other scenario is that we quickly want to start just a few services to test or reproduce something without starting the complete environment. Therefore, I placed the buttons on the overview page instead of the service page, and added a command-line option to skip startup for specific projects (eg we have a Microsoft Fhir server project in there taking quite some time and resources). Now I could also say skip "*" so no project starts automatically and just spint up like the 3 services I need atm from the dashboard

This PR also works for docker containers that are running + I chose to reuse the created method to start the services by adding a reference to the method on the service object. This way we don't have to inject the processrunner anywhere.

@csteeg csteeg requested a review from philliphoff as a code owner December 23, 2022 10:03
@csteeg csteeg changed the title Csteeg/feature/add startstop Add start/stop option to dashboard and command line option to disable auto-start Dec 23, 2022
@davidfowl
Copy link
Member

davidfowl commented Dec 31, 2022

Seems like alot of features in a single PR. Can you split these out into separate changes? Seems like your ingress changes are in here too. I assume that's unintentional?

@csteeg
Copy link
Contributor Author

csteeg commented Jan 2, 2023

Yes sorry about that, I created my new wishes (there are even more on my current main branch) in one branch hoping that I could do them 1 by 1, but decided to pick the features and create a PR for them separately later. This one now only contains the start/stop feature

@allensiho
Copy link

Looks like great feature,
If merged how long before available to public?
Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants