JSON does not allow trailing commas #7876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
@iratebadger: thanks for the pull request; the build failures look like something has just broken in our build system in the last 24 hours or so and we'll need to chase that down. |
|
@iratebadger Can you please link to or share examples of the problems this is causing? Not that I am necessarily against this change, but VSCode itself uses both comments and trailing commas in their themes. |
|
@iratebadger Do you have an example we could use here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This json is causing errors in other extensions for some reason. Lets use valid json. Filtering the comments is easy, fixing trailing commas is hard.