Implement context provider #7921
Conversation
| const ext = vscode.extensions.getExtension('github.copilot'); | ||
| if (!ext) { | ||
| channel.debug('GitHub Copilot extension not installed. Skip registeration of C# related files provider.'); | ||
| return; | ||
| return undefined; |
There was a problem hiding this comment.
I would keep the log messages if possible (trace/debug only though)
| try { | ||
| return await ext.activate(); | ||
| } catch { | ||
| return undefined; |
There was a problem hiding this comment.
Is the catch necessary here? There is already a .catch in the caller which also logs the error.
If you're keeping this catch here, it definitely needs to log the error.
| } catch { | ||
| return undefined; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
no need for the if else here. activate should no-op if already active
| selector: [{ language: 'csharp' }], | ||
| resolver: { | ||
| resolve: async (request, token) => { | ||
| return [{ uri: 'testUri', value: 'testValue', additionalUris: [] }]; |
There was a problem hiding this comment.
assuming this is the part that will eventually call out to the server
| return undefined; | ||
| } | ||
| } else { | ||
| return ext.exports as CopilotAPIs | undefined; |
There was a problem hiding this comment.
guessing this fails if the interface definition doesn't match? e.g. the version of the extension doesn't have a getContextProviderAPI export?
|
Closed in favor of an alternative approach |
No description provided.