Skip to content

Commit

Permalink
Respond to Breaking Change in Releases.Json (#2129)
Browse files Browse the repository at this point in the history
* Support other possible future domains for the installer files.

Resolves #2126
Resolves #2125

Workaround fix for #2123

We have a list of possible safe domains as part of our threat model which is needed to verify the source of truth when we run executables with elevated permission. In the past releases json only hosted downloads on `download.visualstudio.microsoft.com` but now it can be `builds.dotnet.microsoft.com`. I've added some more urls to our azure front door and other CDNs in the event that we decide to change to those.

The long term fix for this would be if signatures are ever published for releases.json to verify those instead, but that is not ready yet and this change needs to go in.

* Fix the test

* Change URLs to possible likely download stores

Co-authored-by: Rich Lander <[email protected]>

---------

Co-authored-by: Rich Lander <[email protected]>
  • Loading branch information
nagilson and richlander authored Feb 11, 2025
1 parent bc23ec1 commit 902fc96
Show file tree
Hide file tree
Showing 3 changed files with 26,562 additions and 86 deletions.
Loading

0 comments on commit 902fc96

Please sign in to comment.