Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnetcli domain #2089

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update dotnetcli domain #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/global-installs/linux-global-install-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ To do the install on linux, we just run the `installCommand`.

### Newest on Win/Mac -- The Available SDK API:
This uses the data from:
https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json
https://builds.dotnet.microsoft.com/dotnet/release-metadata/releases-index.json

We created an API to get the newest SDKs available that were in support. We can use this for Windows and Mac to tell which SDK to use.

Expand Down
2 changes: 1 addition & 1 deletion vscode-dotnet-runtime-library/src/Acquisition/GlobalInstallerResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ Visit https://dotnet.microsoft.com/platform/support/policy/dotnet-core for suppo
*/
private getIndexUrl(majorMinor : string ) : string
{
return `https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/${majorMinor}/releases.json`;
return `https://builds.dotnet.microsoft.com/dotnet/release-metadata/${majorMinor}/releases.json`;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion vscode-dotnet-runtime-library/src/Acquisition/VersionResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { DotnetInstallMode } from './DotnetInstallMode';

export class VersionResolver implements IVersionResolver {
protected webWorker: WebRequestWorker;
private readonly releasesUrl = 'https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json';
private readonly releasesUrl = 'https://builds.dotnet.microsoft.com/dotnet/release-metadata/releases-index.json';

constructor(
private readonly context : IAcquisitionWorkerContext,
Expand Down
10 changes: 5 additions & 5 deletions vscode-dotnet-runtime-library/src/test/mocks/mock-releases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"support-phase": "maintenance",
"release-type" : "lts",
"eol-date": "2019-12-23",
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/2.2/releases.json"
"releases.json": "https://builds.dotnet.microsoft.com/dotnet/release-metadata/2.2/releases.json"
},
{
"channel-version": "2.1",
Expand All @@ -24,7 +24,7 @@
"release-type" : "lts",
"support-phase": "lts",
"eol-date": null,
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/2.1/releases.json"
"releases.json": "https://builds.dotnet.microsoft.com/dotnet/release-metadata/2.1/releases.json"
},
{
"channel-version": "2.0",
Expand All @@ -37,7 +37,7 @@
"release-type" : "lts",
"support-phase": "eol",
"eol-date": "2018-10-01",
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/2.0/releases.json"
"releases.json": "https://builds.dotnet.microsoft.com/dotnet/release-metadata/2.0/releases.json"
},
{
"channel-version": "1.1",
Expand All @@ -50,7 +50,7 @@
"release-type" : "lts",
"support-phase": "eol",
"eol-date": "2019-06-27",
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/1.1/releases.json"
"releases.json": "https://builds.dotnet.microsoft.com/dotnet/release-metadata/1.1/releases.json"
},
{
"channel-version": "1.0",
Expand All @@ -63,7 +63,7 @@
"release-type" : "lts",
"support-phase": "eol",
"eol-date": "2019-06-27",
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/1.0/releases.json"
"releases.json": "https://builds.dotnet.microsoft.com/dotnet/release-metadata/1.0/releases.json"
}
]
}
2 changes: 1 addition & 1 deletion vscode-dotnet-runtime-library/src/test/unit/WebRequestWorker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ chai.use(chaiAsPromised);

const maxTimeoutTime = 10000;
// Website used for the sake of it returning the same response always (tm)
const staticWebsiteUrl = 'https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/2.1/releases.json';
const staticWebsiteUrl = 'https://builds.dotnet.microsoft.com/dotnet/release-metadata/2.1/releases.json';

suite('WebRequestWorker Unit Tests', () => {
test('Acquire Version Network Failure', async () => {
Expand Down
2 changes: 1 addition & 1 deletion vscode-dotnet-sdk-extension/src/test/functional/DotnetCoreAcquisitionExtension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ suite('DotnetCoreAcquisitionExtension End to End', function()
const newestVersion = '6.0.408';
const mockAcquisitionContext = getMockAcquisitionContext('sdk', '');

const url = 'https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/6.0/releases.json'
const url = 'https://builds.dotnet.microsoft.com/dotnet/release-metadata/6.0/releases.json'
const webWorker = new MockIndexWebRequestWorker(mockAcquisitionContext, url);
webWorker.knownUrls.push(url);
// Note that ZIPS in the data below come before EXEs to make sure the file extension check works.
Expand Down