Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for FlowPanelDesigner #11735

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Add unit tests for FlowPanelDesigner #11735

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27297b5
Add unit tests for FlowPanelDesigner
Olina-Zhang Jul 23, 2024
8f87f33
update
Olina-Zhang Jul 24, 2024
f6a6314
Remove panel returning
Olina-Zhang Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions ...indows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FlowPanelDesignerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#nullable enable

using Moq;
using System.ComponentModel;
using System.ComponentModel.Design;
using System.Windows.Forms.Design.Behavior;

namespace System.Windows.Forms.Design.Tests;

public sealed class FlowPanelDesignerTests
{
private (Panel panel, FlowPanelDesigner designer) SetupDesignerWithPanel()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panel never seems to be used in the tests. Let's remove returning it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

designer.Initialize(panel) : the panel is passed to the Initialize method of FlowPanelDesigner. This step associates the FlowPanelDesigner with the Panel, allowing the designer to perform operations on the Panel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, designer.Initialize(panel) is still necessary, but we do not need to return panel from this method since it is not used outside of this method. Signature for this method could just be :

private FlowPanelDesigner SetupDesignerWithPanel()

{
var mockHost = new Mock<IDesignerHost>();
var mockContainer = new Mock<IContainer>();
mockHost.Setup(host => host.Container).Returns(mockContainer.Object);

Panel panel = new();
mockContainer.Object.Add(panel);

FlowPanelDesigner designer = new();
designer.Initialize(panel);

return (panel, designer);
}

[Fact]
public void ParticipatesWithSnapLines_ShouldAlwaysReturnFalse()
{
var (_, designer) = SetupDesignerWithPanel();

designer.ParticipatesWithSnapLines.Should().BeFalse();
}

[Fact]
public void SnapLines_ShouldNotContainPaddingSnapLines()
{
var (_, designer) = SetupDesignerWithPanel();

var snapLines = designer.SnapLines as IList<SnapLine>;

snapLines.Should().NotBeNull();
snapLines.Should().NotContain(line => line.Filter is object && line.Filter.Contains(SnapLine.Padding));
}

[Fact]
public void SnapLines_ShouldReturnNonPaddingSnapLines()
{
var (_, designer) = SetupDesignerWithPanel();

var snapLines = designer.SnapLines as IList<SnapLine>;

snapLines.Should().NotBeNull();
snapLines.Should().Contain(line => line.Filter == null || !line.Filter.Contains(SnapLine.Padding));
}
}