Merged
Conversation
Updates to the latest release of CSWin32 and updates code where necessary. Also add back explicit span casts where VS IntelliSense is unable to differentiate. Without this contributors would need to have access to internal preview feeds.
lonitra
previously approved these changes
Oct 8, 2024
| --> | ||
| <MicrosoftNETCoreILAsmVersion>$(MicrosoftNETCoreILAsmPackageVersion)</MicrosoftNETCoreILAsmVersion> | ||
| <MicrosoftWindowsCsWin32PackageVersion>0.3.75-beta</MicrosoftWindowsCsWin32PackageVersion> | ||
| <MicrosoftWindowsCsWin32PackageVersion>0.3.106</MicrosoftWindowsCsWin32PackageVersion> |
Member
There was a problem hiding this comment.
What metadata version is cswin32 using? Perhaps we can also close out #10348 if it is using v57+?
Member
Author
There was a problem hiding this comment.
SDK: 60.0.34, WDK: 0.11.4
lonitra
approved these changes
Oct 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12290 +/- ##
===================================================
- Coverage 75.46707% 75.46202% -0.00506%
===================================================
Files 3106 3106
Lines 634437 634445 +8
Branches 46886 46887 +1
===================================================
- Hits 478791 478765 -26
- Misses 152222 152250 +28
- Partials 3424 3430 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the latest release of CSWin32 and updates code where necessary.
Also add back explicit span casts where VS IntelliSense is unable to differentiate. Without this contributors would need to have access to internal preview feeds.
Microsoft Reviewers: Open in CodeFlow