Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewColumnConverter #12766

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jan 13, 2025

related #10453

Proposed changes

Add unit tests for DataGridViewColumnConverter.cs to test its methods

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02113%. Comparing base (ce6b6c2) to head (89f8082).
Report is 31 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12766          +/-   ##
====================================================
+ Coverage   76.14673%   97.02113%   +20.87439%     
====================================================
  Files           3191        1199        -1992     
  Lines         640105      355907      -284198     
  Branches       47233        5463       -41770     
====================================================
- Hits          487419      345305      -142114     
+ Misses        149166        9796      -139370     
+ Partials        3520         806        -2714     
Flag Coverage Δ
Debug 97.02113% <100.00000%> (+20.87439%) ⬆️
integration ?
production ?
test 97.02113% <100.00000%> (-0.00649%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jan 13, 2025
@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 14, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 15, 2025
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jan 15, 2025
ricardobossan
ricardobossan previously approved these changes Jan 15, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 16, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@Tanya-Solyanik Tanya-Solyanik merged commit 3b8e1a6 into dotnet:main Jan 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 16, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_DataGridViewColumnConverter branch January 16, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants