Add unit tests for FocusableLabel#12773
Merged
ricardobossan merged 6 commits intodotnet:mainfrom Feb 5, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12773 +/- ##
===================================================
- Coverage 76.18076% 76.10286% -0.07790%
===================================================
Files 3193 3256 +63
Lines 640306 642897 +2591
Branches 47237 47316 +79
===================================================
+ Hits 487790 489263 +1473
- Misses 148983 150075 +1092
- Partials 3533 3559 +26
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
reviewed
Jan 15, 2025
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
previously approved these changes
Jan 16, 2025
LeafShi1
added
the
waiting-review
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
waiting-author-feedback
ricardobossan
dismissed
their stale review
New review added comments to be addressed
dotnet-policy-service
bot
removed
the
waiting-author-feedback
ricardobossan
requested changes
Jan 23, 2025
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
waiting-author-feedback
chaowendy
added
waiting-review
ricardobossan
added
waiting-author-feedback
ricardobossan
requested changes
Jan 27, 2025
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/FocusableLabelTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
removed
the
waiting-author-feedback
ricardobossan
approved these changes
Feb 5, 2025
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
* Add unit tests for FocusableLabel * grammar error * update * null&false * no reflection * add the new keyword --------- Co-authored-by: v-chaowendy <v-chaowendy@24H2W11>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Microsoft Reviewers: Open in CodeFlow