[release/9.0] WinForms ComboBox border and drop down button are not visible sometimes #12785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#12744 ## Root Cause - Regression introduced by PRs 11529 and 11761, which modified how `ComboBox` controls would be drawn. ## Proposed changes - Revert code from PRs 11529 and 11761. ## Customer Impact - `ComboBox` button can be shown normally when switching RightToLeft property, or recreating the `ComboBox` for any other reason. ## Regression? - Yes ## Risk - Minimal ## Screenshots ### Before ### After ## Test methodology - Manual ## Test environment(s) - 9.0.100
ricardobossan
requested review from
Tanya-Solyanik,
lonitra,
LeafShi1 and
Epica3055
ricardobossan
added
🚫 * NO-MERGE *
Tanya-Solyanik
added
the
waiting-for-testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12785 +/- ##
=====================================================
+ Coverage 74.83507% 74.83752% +0.00244%
=====================================================
Files 3022 3022
Lines 630413 630395 -18
Branches 46798 46795 -3
=====================================================
+ Hits 471770 471772 +2
+ Misses 155250 155238 -12
+ Partials 3393 3385 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Jan 14, 2025
Tanya-Solyanik
removed
the
waiting-review
|
Tested this PR, affected issues were fixed, no new issue found. |
Olina-Zhang
removed
the
waiting-for-testing
Tanya-Solyanik
changed the title
Tanya-Solyanik
changed the title
Tanya-Solyanik
added
servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #12737 to 9.0
Fixes #12744
Fixes #12590
Customer Impact
ComboBoxdrop down button disappears when switching RightToLeft property, or recreating theComboBoxfor any other reason.ComboBoxfocus border is not shown when TAB-ing into ToolStripComboBoxItemRoot Cause
ComboBoxcontrols was be drawn. It was an attempt to fix flickering of the control border when the mouse hovers over the control by reducing the number of times control is re-drawn, but we missed some cases where re-drawing was required. We don't have a better fix for the original flickering issue at the moment.Proposed changes
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow