Skip to content

Fix DarkMode Button Render #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

memoarfaa
Copy link

@memoarfaa memoarfaa commented May 13, 2025

Fix Dark Mode Button Render

Fixes #11949

Microsoft Reviewers: Open in CodeFlow

@memoarfaa memoarfaa requested a review from a team as a code owner May 13, 2025 02:07
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label May 13, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.59961%. Comparing base (5821493) to head (324c983).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13446          +/-   ##
====================================================
+ Coverage   62.21083%   76.59961%   +14.38877%     
====================================================
  Files           3213        3230          +17     
  Lines         638302      639109         +807     
  Branches       47201       47291          +90     
====================================================
+ Hits          397093      489555       +92462     
+ Misses        234153      145977       -88176     
+ Partials        7056        3577        -3479     
Flag Coverage Δ
Debug 76.59961% <61.53846%> (+14.38877%) ⬆️
integration 18.78449% <61.53846%> (-0.00429%) ⬇️
production 51.00296% <61.53846%> (+32.21417%) ⬆️
test 97.40411% <ø> (ø)
unit 48.38808% <61.53846%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann
Copy link
Member

Hey @memoarfaa,

thanks so much for that contribution.

We will first need to become independent of the internal Visual Styles renderers, so that if Windows changes, we're still have a reliable fallback mechanism.

Next step will be to consider using your approach for SystemButton Rendering.
We will discuss this in the scope for Preview 6.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DarkMode Issues relating to Dark Mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark Mode] Button with FlatStyle 'Standard' is not in dark mode on 100% dpi after enabled SystemColorMode.Dark
2 participants