Removed separate MinHeight resources for text based controls #10980
+45
−86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts a workaround that I had to introduce while fixing the layout of text controls ( DatePicker, TextBox, RichTextBox, PasswordBox, etc ). These all controls use a shared resource TextControlThemeMinHeight, which needed to be changed from 24 to 32. However, in each PR I only fixed a single style, I had to introduce individual resources for these controls at the time.
In this PR, I remove the extra resources and their references are replaced with TextControlThemeMinHeight resource.
Customer Impact
Anyone modifying this resource will see the uniform behavior for all text based controls.
Regression
N/A
Testing
Local app testing
Risk
Minimal. Minor issues in content alignment may come up.
Microsoft Reviewers: Open in CodeFlow