Skip to content

Removed separate MinHeight resources for text based controls #10980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Jul 15, 2025

Description

This PR reverts a workaround that I had to introduce while fixing the layout of text controls ( DatePicker, TextBox, RichTextBox, PasswordBox, etc ). These all controls use a shared resource TextControlThemeMinHeight, which needed to be changed from 24 to 32. However, in each PR I only fixed a single style, I had to introduce individual resources for these controls at the time.

In this PR, I remove the extra resources and their references are replaced with TextControlThemeMinHeight resource.

Customer Impact

Anyone modifying this resource will see the uniform behavior for all text based controls.

Regression

N/A

Testing

Local app testing

Risk

Minimal. Minor issues in content alignment may come up.

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings July 15, 2025 18:10
@dipeshmsft dipeshmsft requested a review from a team as a code owner July 15, 2025 18:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the minimum height values for text-based controls by removing separate control-specific MinHeight resources and standardizing them to use a unified TextControlThemeMinHeight value of 32. The changes eliminate redundant resource definitions and ensure consistent sizing across different text input controls while improving maintainability through centralized resource management.

  • Unified MinHeight resource consolidation from separate control-specific values to a single TextControlThemeMinHeight
  • Updated the base TextControlThemeMinHeight value from 24 to 32 across all theme files
  • Improved vertical content alignment for ComboBox controls from "Top" to "Center"

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Fluent.xaml Updates central theme with unified MinHeight resources and removes deprecated control-specific MinHeight values
Fluent.Light.xaml Applies same consolidation changes for light theme variant
Fluent.Dark.xaml Applies same consolidation changes for dark theme variant
Fluent.HC.xaml Applies same consolidation changes for high contrast theme variant
TextBox.xaml Removes deprecated TextBoxThemeMinHeight resource and updates references
RichTextBox.xaml Removes deprecated RichTextBoxThemeMinHeight resource and updates references
PasswordBox.xaml Removes deprecated PasswordBoxThemeMinHeight resource and updates references
DatePicker.xaml Adds MinHeight property and updates template binding for consistent sizing
ComboBox.xaml Updates MinHeight reference and improves vertical content alignment
Variables.xaml Updates base TextControlThemeMinHeight value from 24 to 32

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.51885%. Comparing base (900946a) to head (5d2d3b3).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10980         +/-   ##
===================================================
+ Coverage   13.36769%   13.51885%   +0.15116%     
===================================================
  Files           3319        3319                 
  Lines         664894      664894                 
  Branches       74674       74674                 
===================================================
+ Hits           88881       89886       +1005     
+ Misses        573472      572462       -1010     
- Partials        2541        2546          +5     
Flag Coverage Δ
Debug 13.51885% <ø> (+0.15116%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant