Skip to content

fixes to build libnodave and use it on Linux #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zati-
Copy link

@zati- zati- commented Jul 24, 2025

  • fixees to libnodave code to compile correctly with gcc in linux
  • fix to Makefile to build libnodave in linux
  • fixes to libnodave p/invoke to correctly call libnodave functions

@jogibear9988
Copy link
Member

I don't get what this is about?
It was intentionally changed to Intptr, so the lib could used on 32 and 64 bit systems.
So I don't get why you would change this.

@zati-
Copy link
Author

zati- commented Jul 25, 2025

Linux definition in nodave.h for dost structure is

#ifdef LINUX
#define DECL2
#define EXPORTSPEC
	typedef struct dost {
		int rfd;
		int wfd;
		//    int connectionType;
	} _daveOSserialType;
#include <stdlib.h>
#define tmotype int
#define OS_KNOWN	// get rid of nested ifdefs.
#endif    

so it's always 32 bits.

@jogibear9988
Copy link
Member

Then maybe this needs to be fixed? The other changes I could not merge, i need 64 bit windows support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants