Skip to content

Minor Changes on Top of Isamus EXL2 PR (Docs, Enable FSM/CFG, Fix Tokenizer) #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

lapp0
Copy link
Contributor

@lapp0 lapp0 commented Oct 5, 2024

@isamu-isozaki did a great job implementing a fully functioning outlines.models.exllamav2. This PR introduces minor fixes and a documentation update.

This PR rebases with main and squashes his commits into one: d1f5609

Changes

New

  • Automatically download necessary models for tests to run successfully
  • Make OutlinesExLlamaV2Tokenizer, which is compatible with cfg
  • For models.exllamav2 enable generate.cfg and generate.fsm
  • Document how to install third party ExLlamaV2 with logits processor functionality

Closes

@lapp0 lapp0 changed the title Minor Changes to Isamus ExLlamaV2 PR (Docs, enable FSM/Generate, Clean Tokenizer) Minor Changes on Top of Isamus EXL2 PR (Docs, Enable FSM/CFG, Fix Tokenizer) Oct 5, 2024
isamu-isozaki and others added 3 commits October 5, 2024 00:14
Fix comment

Fixed precommit issues

Removed text

Basic draft done

Passed local test

Fixed tests+precommit

Revert change for pyairports

Fixed precommit

Wrap up

Remove | for union

Attempt changing to List

Fixed for 3.8

Adding exllamav2 to optional dependency

Fixed model

Changed to fork

Fix format

Changed order

Skip exllamav2 tests

Attempt fixing coverage

Attempt fix coverage

Remove flash-attn requirement

Fixed fixture tests

Removed lora

Passed coverage

Added back transformers install

Fixed per review

Made coverage 100%
fix exl bug: sometimes piece_to_id not populated, but get_piece_to_id() still works

fix exl bug: sometimes piece_to_id not populated, but get_piece_to_id() still works

enable exl2 in generate.cfg

cleate OutlinesExLlamaV2Tokenizer rather than monkey patching
@lapp0 lapp0 force-pushed the exllamav2_filter branch from 4770023 to a59c26f Compare October 5, 2024 04:14
@lapp0 lapp0 marked this pull request as ready for review October 5, 2024 04:14
@rlouf rlouf merged commit 0da7039 into dottxt-ai:main Oct 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exllamav2 integration Update the exllamav2 integration
3 participants