Migrate timeout and unauthorised error states to Angular/TypeScript#1174
Open
m1chael-pappas wants to merge 2 commits intodoubtfire-lms:10.0.xfrom
Open
Migrate timeout and unauthorised error states to Angular/TypeScript#1174m1chael-pappas wants to merge 2 commits intodoubtfire-lms:10.0.xfrom
m1chael-pappas wants to merge 2 commits intodoubtfire-lms:10.0.xfrom
Conversation
…TypeScript Migrate the timeout and unauthorised error state components from CoffeeScript/AngularJS to Angular/TypeScript as part of the ongoing migration effort. Both components preserve their original behaviour.
Delete empty errors.coffee and states.coffee files that were left behind after migrating to Angular components, and remove the AngularJS module dependency.
Author
|
Ready for review. @macite @jakerenzella |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi! This is my first contribution to the project. I noticed the ongoing migration from CoffeeScript/AngularJS to Angular/TypeScript and wanted to help out.
This PR migrates the
timeoutandunauthorisederror state components:.coffeeand.tpl.htmlfiles with Angular.component.ts,.component.html, and.component.scssdoubtfire.states.tsdoubtfire-angular.module.tsanddoubtfire-angularjs.module.tserrors/states/states.coffeeto remove migrated module dependenciesBoth components preserve the original behaviour:
Type of change
How Has This Been Tested?
Ran the application locally via Docker Compose and verified both routes render correctly and match the original component behaviour. Confirmed the timeout page auto-signs out after 2 seconds and the unauthorised page displays the correct message.
Testing Checklist:
Checklist: