Skip to content

Add pre-commit hooks#11

Closed
WeilerP wants to merge 4 commits intomainfrom
feat/pre_commit_hooks
Closed

Add pre-commit hooks#11
WeilerP wants to merge 4 commits intomainfrom
feat/pre_commit_hooks

Conversation

@WeilerP
Copy link
Contributor

@WeilerP WeilerP commented Jan 29, 2026

New

  • .pre-commi-config.yaml: Pre-commit configuration file.

Changes

  • Run pre-commit hooks and update files to pass hooks.

Related issues

Closes #10.

* Adds `.pre-commit-config.`
* Updates `pyproject.toml`
@WeilerP WeilerP requested a review from andrewmoorman January 29, 2026 19:43
@WeilerP
Copy link
Contributor Author

WeilerP commented Jan 29, 2026

@andrewmoorman, you still need to fix the issues that are causing the CI to fail; otherwise, everything should be set up.

@WeilerP WeilerP force-pushed the feat/pre_commit_hooks branch from aa4f37d to 8688adc Compare January 29, 2026 19:57
@Tobiaspk
Copy link
Collaborator

We should merge this. Id suggest to split into 2 PRs since this is currently behind:

  1. Add pre-commit hooks and settings as you suggested
  2. Apply to main branch

@WeilerP
Copy link
Contributor Author

WeilerP commented Feb 25, 2026

@Tobiaspk, it might actually make more sense to directly use the pre-commit setups from the latest scverse cookiecutter template that uses uv, biome, etc. I used an outdated setup here.

@Tobiaspk
Copy link
Collaborator

Ok. Closing this in favor of a new PR using the latest pre-commit. Thanks @WeilerP

@Tobiaspk Tobiaspk closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-commit hooks

2 participants