forked from micropython/micropython
-
Notifications
You must be signed in to change notification settings - Fork 12
proposal: run-multitests.py --target-wiring #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hmaerki
wants to merge
34
commits into
dpgeorge:tests-improvements-for-octoprobe
Choose a base branch
from
octoprobe:multitests-PICO-infra
base: tests-improvements-for-octoprobe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
proposal: run-multitests.py --target-wiring #20
hmaerki
wants to merge
34
commits into
dpgeorge:tests-improvements-for-octoprobe
from
octoprobe:multitests-PICO-infra
+463
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien George <[email protected]>
Some boards define ESP32C3, some define ESP32-C3. Probably it should just use default pins, eg SPI(1). Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Eg for ESP8266-512K. Signed-off-by: Damien George <[email protected]>
In --via-mpy --emit native mode. Signed-off-by: Damien George <[email protected]>
On ESP8266 this test can fail with --via-mpy. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Because RP2350 uses float-abi=softfp! Maybe we should change that somehow? Could also use `defined(__SOFTFP__)` to detect soft (all software fp) or softfp (hardware for calculations but soft/integer for passing arguments). Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Tested on ADAFRUIT_ITSYBITSY_M0_EXPRESS. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
On bare-metal lwIP targets, there's only enough buffer space for 4 groups. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
The test runner will abort with error code 2 if: - the target could not be detected (enter_raw_repl failed at the detection stage) - unittest is not installed but is needed Signed-off-by: Damien George <[email protected]>
Now, if a test fails and crashes a board to the point it no longer responds
(but the serial connection is still alive and able to read/write), it only
takes a maximum of 30 + 5 * 4 = 50 seconds to detect that state and exit
the test run (previously it would be 30 + 10 seconds * number of remaining
tests = potentially large).
Can test this by adding the following to a test:
import time, micropython
micropython.kbd_intr(-1)
while 1:
time.sleep(1)
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Because it needs internet connection it must be in a test directory that is expected to have internet connection. Also, this test can be made to run on more targets in the future. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Otherwise the test will fail with --via-mpy because the mounted __FS object will allow any file to be opened. Signed-off-by: Damien George <[email protected]>
To reduce heap memory use. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
This moves the `port:<dev>` check for the test instance to the `convert_device_shortcut_to_real_device()` helper function, which means that `run-multitests.py` can use this specification. Signed-off-by: Damien George <[email protected]>
If `time.time` doesn't exist, it tries to use `globals()['time']` which is the time module itself, and that causes the test to fail. Instead it should just skip `time.time`. Signed-off-by: Damien George <[email protected]>
Signed-off-by: Damien George <[email protected]>
They don't have the `freq` argument. Signed-off-by: Damien George <[email protected]>
So it can be properly skipped. Signed-off-by: Damien George <[email protected]>
39ba8fe to
e143b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See my comments in octoprobe/testbed_micropython#57