Skip to content

spectate: Remove spawned check for spectator #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

spectate: Remove spawned check for spectator #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/module/spectate.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
function onKeyDown( player, key ) {

if(player.Spawned) {
return;
}
// if(player.Spawned) {
// return;
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving dead code is bad.

We should have some can_always_spectate <- true; (near the top) which disables this check (and is self-describing).
Alternatively, if we decide we never want to restrict spectating this way: remove this code altogether.

But commenting out unused code is bad practice.


if ( key == BIND_SPEC_NEXT ) {
if( player.SpectateTarget != null) {
Expand Down