keybind: Add /bind keybinding command #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracc
commented
Feb 27, 2019
dracc
commented
Feb 27, 2019
dracc
commented
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
JayFoxRox
reviewed
Feb 27, 2019
| firstSpace = input.len()-1; | ||
| } else { | ||
| ret[1] = input.slice(firstSpace+1); | ||
| } |
There was a problem hiding this comment.
Wouldn't this return ["foo", null] for "foo" with "bar" separator? Why not ["foo", ""] to keep away edge cases?
There was a problem hiding this comment.
You are right. My trail of thought was that the used functions return null when unsuccessful and it felt to me like the most intuitive way to go would be to continue with that tradition.
JayFoxRox
reviewed
Feb 28, 2019
JayFoxRox
reviewed
Feb 28, 2019
JayFoxRox
reviewed
Feb 28, 2019
JayFoxRox
reviewed
Feb 28, 2019
JayFoxRox
reviewed
Feb 28, 2019
dracc
changed the title
dracc
commented
Mar 1, 2019
|
I'd say that this is ready for merge as soon as I've squashed the commits. |
Store a table server- and client-side per session Send commands from client keybind over socket to server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Still untested.I've tested this a bit, found a couple of bugs, fixed those and am now happy with the function of the script.