chore: Use pipeline whenever possible in pytests #4459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't use FakeRedis we can always use pipeline / multi-exec. However, we can also use FakeRedis with multi-exec during migrations, because migrations wait for such operations to complete before finalization. We can't use FakeRedis with regular pipelines though because it may cause non deterministic comparisons.
|
@adiholden I think that this PR won't work, because in cases of OOM we reject commands (and break the transaction-ness of |
Ok I understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't use FakeRedis we can always use pipeline / multi-exec. However, we can also use FakeRedis with multi-exec during migrations, because migrations wait for such operations to complete before finalization. We can't use FakeRedis with regular pipelines though because it may cause non deterministic comparisons.