feat: add Lua GC flags #5194
Merged
feat: add Lua GC flags #5194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
May 29, 2025
romange
reviewed
May 29, 2025
src/core/interpreter.cc
Outdated
| @@ -1109,6 +1203,16 @@ Interpreter* InterpreterManager::Get() { | |||
| } | |||
|
|
|||
| void InterpreterManager::Return(Interpreter* ir) { | |||
| static const uint64_t max_memory_usage = absl::GetFlag(FLAGS_lua_mem_usage_force_gc); | |||
There was a problem hiding this comment.
i would imagine we would like to change these flags without restarting the process.
please add support to "CONFIG SET" as well.
romange
requested changes
Jun 3, 2025
src/server/main_service.cc
Outdated
| @@ -821,6 +821,8 @@ void Service::Init(util::AcceptServer* acceptor, std::vector<facade::Listener*> | |||
|
|
|||
| config_registry.RegisterMutable("pipeline_squash"); | |||
|
|
|||
| config_registry.RegisterMutable("lua_mem_usage_force_gc"); | |||
There was a problem hiding this comment.
that's won't cut it and you have not tested that it works.
you used static const uint64_t max_memory_usage = ... so it will be initialised only once
romange
requested changes
Jun 4, 2025
romange
reviewed
Jun 4, 2025
romange
reviewed
Jun 4, 2025
romange
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added 2 flags:
I have done some tests with lua_mem_usage_force_gc, and it shows quite good results to my mind, and it works fast.
Regarding the luagc flag, I've tried to use different parameters, according to https://www.lua.org/manual/5.4/manual.html#2.5.1 , and the results were insignificant, but with aggressive parameters performance can be dropped significantly