Skip to content

fix(pytest): Increase REPLTAKOVER time in test_take_over_seeder #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

fix(pytest): Increase REPLTAKOVER time in test_take_over_seeder #5415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/dragonfly/replication_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,7 +1294,7 @@ async def info_replication():
# Give the seeder a bit of time.
await asyncio.sleep(3)
logging.debug("running repltakover")
await c_replica.execute_command(f"REPLTAKEOVER 10 SAVE")
await c_replica.execute_command(f"REPLTAKEOVER 30 SAVE")
Copy link
Contributor

@kostasrim kostasrim Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So were not robust enough? 😮‍💨

Copy link
Contributor Author

@mkaruza mkaruza Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks that with latest changes in replication and because of this 4->2 we don't takeover in time. I have run several tests on (#5392) with this increase and it seems that it is successful on all runs.

logging.debug("after running repltakover")
seeder.stop()
await fill_task
Expand Down
Loading