chore: add a task that periodically updates the expire base time #5956
+168
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task is run during cpu idle periods. It starts refreshing the base after several days. During the updates there are two bases and only one that is currently active: expire_gen_id_ 1. The update process concludes when it reaches end of the traversal and it did not skip any values that should be updated. 2. It skips values when it encounters expired times as it can not delete values in the scope of the task. Signed-off-by: Roman Gershman <[email protected]>
kostasrim
reviewed
Oct 24, 2025
Comment on lines
+38
to
+40
| bool is_second_precision() { | ||
| return precision_ == 1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| bool is_second_precision() { | |
| return precision_ == 1; | |
| } | |
| bool is_second_precision() const { | |
| return precision_ == 1; | |
| } |
kostasrim
reviewed
Oct 24, 2025
| if (update_expire_state_->db_index >= db_slice.db_array_size()) { | ||
| if (update_expire_state_->stale_entries == 0) { | ||
| // We went over all the items and not stale items were found, we are done. | ||
| delete update_expire_state_; |
There was a problem hiding this comment.
I haven't followed the logic of this function completely but this seems dangerous if the state is kept among different idle runs of this function. Why ? Because:
- IdleTsk runs -> allocates update_expire_state_
- We exit so we don't run the task again
- Memory leak since we don't call
delete update_expire_state_anywhere else
There was a problem hiding this comment.
IdleTask exits only on process shutdown. if it concludes the traversal, it deletes the state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task is run during cpu idle periods. It starts refreshing the base after several days. During the updates there are two bases and only one that is currently active: expire_gen_id_
The update process concludes when it reaches end of the traversal and it did not skip any values that should be updated.
It skips values when it encounters expired times as it can not delete values in the scope of the task.