Simplify ActiveModelSupport? #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good! I don't remember why the're so complex, to be honest. |
steveklabnik
added a commit
that referenced
this pull request
Oct 11, 2012
Simplify ActiveModelSupport?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really get why
ActiveModelSupportis so complicated.If I understand correctly (and it's quite likely that I don't!), the point is to proxy
to_param,errors, andidto the model, provided they are defined on the model but not on the decorator. But isn't this exactly what Draper does with any other method?!Granted,
to_paramis defined onDecoratorthanks to ActiveSupport, so it won't be delegated out of the box, but I think we can handle that case by always delegating it.If I strip it back to basics, leaving just what you see in this pull request, all the specs stay green!
I must have gotten the wrong end of the stick, right?