CI against Ruby 3.4 #939
Merged
CI against Ruby 3.4 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
commented
Jan 14, 2025
spec/draper/decorator_spec.rb
Outdated
| @@ -451,7 +451,7 @@ module Draper | |||
| it "includes the context" do | |||
| decorator = Decorator.new(double, context: {foo: "bar"}) | |||
|
|
|||
| expect(decorator.inspect).to include '@context={:foo=>"bar"}' | |||
| expect(decorator.inspect).to include "#{@context={:foo=>"bar"}}" | |||
There was a problem hiding this comment.
Ruby 3.4 has changed the format of Hash.inspect. So I wrapped this with #{} to work both Ruby 3.4 and older.
Ref: https://bugs.ruby-lang.org/issues/20433
Alexander-Senko
requested changes
Jan 14, 2025
|
It seems that Ruby 2.4 is failing with another issue. I will check. |
Maybe the time has come to let it fail? |
In Ruby 3.4, the result of Hash.inspect has changed. So I updated
the specs to wrap hash with `#{}` to work both 3.4 and older.
Ref: https://bugs.ruby-lang.org/issues/20433
Co-authored-by: Alexander Senko <[email protected]>
y-yagi
force-pushed
the
ci_against_ruby34
branch
from
5412d06 to
4bd6472
Compare
Alexander-Senko
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ruby 3.4 has been released. I would like to add Ruby 3.4 to CI to confirm whether
draperworks well with it.