-
Notifications
You must be signed in to change notification settings - Fork 3
Update stale Drasi GitHub links #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: agentofreality <4021243+agentofreality@users.noreply.github.com>
examples/trading/README.md
Outdated
|
|
||
| - [Drasi Documentation](https://drasi.io/) | ||
| - [Drasi Project on GitHub](https://github.com/drasi-project) | ||
| - [Drasi Project on GitHub](https://github.com/drasi-project/drasi-project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the new URL is wrong. it should be https://github.com/drasi-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the Drasi GitHub link to https://github.com/drasi-project and adjusted related references. Commit: a163943.
README.md
Outdated
| - [DrasiLib](https://github.com/drasi-project/drasi-lib) - Core event processing engine | ||
| - [Drasi](https://github.com/drasi-project/drasi) - Main Drasi project | ||
| - [DrasiLib](https://github.com/drasi-project/drasi-core/tree/main/lib) - Core event processing engine | ||
| - [Drasi](https://github.com/drasi-project/drasi-project) - Main Drasi project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the new URL is wrong. it should be https://github.com/drasi-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the Drasi project link is https://github.com/drasi-project; no further changes were needed. Commit: c363d7f.
README.md
Outdated
| - [Drasi](https://github.com/drasi-project/drasi) - Main Drasi project | ||
| - [DrasiLib](https://github.com/drasi-project/drasi-core/tree/main/lib) - Core event processing engine | ||
| - [Drasi](https://github.com/drasi-project/drasi-project) - Main Drasi project | ||
| - [Drasi Documentation](https://drasi.io/docs) - Complete documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot this URL should be https://drasi.io/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the documentation link to https://drasi.io/. Commit: c363d7f.
Co-authored-by: agentofreality <4021243+agentofreality@users.noreply.github.com>
Co-authored-by: agentofreality <4021243+agentofreality@users.noreply.github.com>
Co-authored-by: agentofreality <4021243+agentofreality@users.noreply.github.com>
README.md
Outdated
|
|
||
| - **Issues**: [GitHub Issues](https://github.com/drasi-project/drasi-server/issues) | ||
| - **Discussions**: [GitHub Discussions](https://github.com/drasi-project/drasi/discussions) | ||
| - **Discussions**: [GitHub Discussions](https://github.com/drasi-project/drasi-server/discussions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot delete this line, discussions are not enabled on the Drasi Server repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the Discussions line from the README. Commit: 3cf7b68.
Co-authored-by: agentofreality <4021243+agentofreality@users.noreply.github.com>
YAML Configuration Validation ResultsI've validated all YAML configuration snippets in markdown files against the Rust models. Found 2 critical issues in ❌ Issue 1: Invalid field
|
| ✅ Correct | ❌ Wrong |
|---|---|
defaultTemplate |
default_template |
ssePath |
sse_path |
baseUrl |
base_url |
timeoutMs |
timeout_ms |
autoStart |
auto_start |
Expected Behavior: The server will fail to start with these config errors, reporting "unknown field" messages due to #[serde(deny_unknown_fields)] annotations on all DTO structs.
AI generated by YAML Snippet Validator
- Fix config/server-with-env-vars.yaml: - Remove invalid fields from postgres bootstrapProvider (uses parent source connection) - Remove invalid logLevel field from log reaction - Fix HTTP reaction to use proper routes configuration instead of top-level method - Add missing config files to example_configs_validation_test.rs: - config/server-minimal.yaml - config/server-docker.yaml - config/server-with-env-vars.yaml - tests/integration/getting-started/config.yaml
YAML Configuration Validation ReportI validated all YAML configuration snippets in the markdown files against the Drasi Server's Rust models and found 1 issue that needs to be fixed. ❌ Issue FoundFile: ProblembootstrapProvider:
type: postgres # ❌ WRONG - should be "kind"Expected (based on Rust model)bootstrapProvider:
kind: postgres # ✅ CORRECTRoot CauseThe bootstrap provider configuration uses a tagged enum with #[derive(Debug, Clone, Serialize, PartialEq, ToSchema)]
#[serde(tag = "kind", rename_all = "lowercase")]
pub enum BootstrapProviderConfig {
Postgres(PostgresBootstrapConfigDto),
// ...
}The Impact
Suggested FixChange line 147 in - type: postgres
+ kind: postgres✅ All Other Snippets Validated SuccessfullyI validated 32 YAML snippets across:
Key findings:
Validation Methodology
Recommendations
|
YAML Configuration Snippet Validation ReportSummary✅ Validated all YAML configuration snippets across repository markdown files against Rust models and runtime behavior. Result: Found 2 field naming inconsistencies in tutorial documentation. The YAML examples use incorrect snake_case field names instead of the required camelCase format. Issues FoundIssue #1:
|
- default_template → defaultTemplate - sse_path → ssePath
- persist_config → persistConfig (CLAUDE.md) - auto_start → autoStart (trading README)
Updated documentation comments in example YAML config files to use camelCase property names matching the actual config schema: - timeout_ms → timeoutMs - base_url → baseUrl - sse_path → ssePath - heartbeat_interval_ms → heartbeatIntervalMs - default_template → defaultTemplate - batch_size → batchSize - batch_flush_timeout_ms → batchFlushTimeoutMs - max_retries → maxRetries - connection_retry_attempts → connectionRetryAttempts - initial_connection_timeout_ms → initialConnectionTimeoutMs - window_size → windowSize - report_interval_secs → reportIntervalSecs - adaptive_min_batch_size → adaptiveMinBatchSize - adaptive_max_batch_size → adaptiveMaxBatchSize - adaptive_window_size → adaptiveWindowSize - adaptive_batch_timeout_ms → adaptiveBatchTimeoutMs
YAML Configuration Validation ReportI've validated all YAML configuration snippets in markdown files against the Drasi Server's Rust models. ✅ Overall Status: GoodThe YAML configurations in the repository are well-structured and mostly correct. Field names use proper camelCase formatting as expected by the Rust serde models, and the actual
|
- Fix query autoStart default: true → false (matches code) - Fix PostgreSQL publicationName example: drasi_pub → drasi_publication - Add missing metadata field to gRPC reaction table - Add complete field table for gRPC Adaptive reaction section - Improve Mock source dataType description with node label info
✅ YAML Snippet Validation CompleteI've validated all YAML configuration snippets in markdown files against the Drasi Server's Rust models and existing test infrastructure. SummaryAll YAML snippets are valid! ✨ The repository has excellent test coverage for YAML configuration validation:
Validation CoverageMarkdown files with YAML snippets:
Schema Validation FindingsAll YAML snippets correctly use camelCase field names as required by the Rust DTOs:
Test InfrastructureThe existing test suite provides comprehensive validation: // tests/readme_examples_validation_test.rs
- test_readme_yaml_blocks_are_valid_yaml() - Validates YAML syntax
- test_readme_complete_configs_validate() - Validates against Rust models
- test_readme_minimal_config_example() - Specific example validation
- test_readme_server_settings_example() - Server settings validation
// tests/example_configs_validation_test.rs
- test_all_example_configs_are_valid() - Validates 25+ config files
- Individual tests for each config file (granular validation)Example Config Files ValidatedAll 25+ example configuration files pass validation:
Recommendations
Technical DetailsThe validation leverages Rust's serde with
This ensures YAML field names automatically map to Rust struct fields via serde deserialization. No action required - All YAML snippets are valid and properly tested! 🎉
|
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.