Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form submission event is triggered by a button click #4280

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

strawberry2020
Copy link

The default value of button type in the browser is submit. If you embed univer in form, the click event of the ToolbarButton will trigger the submit event of the form. type should be specified as botton by default.

The button label is specified as button by default.
Copy link

github-actions bot commented Dec 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@strawberry2020 strawberry2020 changed the title Update ToolbarButton.tsx style: button type is specified as botton by default Dec 11, 2024
@strawberry2020 strawberry2020 changed the title style: button type is specified as botton by default fix: form submission event is triggered by a button click Dec 11, 2024
@wzhudev
Copy link
Member

wzhudev commented Dec 31, 2024

@jikkai Please take a look into this as this has been stale for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants