-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the filtered content is not included in the clear #4589
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
Origin Title: fix: the filtered content is not included in the clear Title: fix: the filtered content is not included in the clear close https://github.com/dream-num/univer-pro/issues/3978 删除行暂时没处理,因为删除行需要先把这个mutation修改为参数类型为ranges Pull Request Checklist
|
Playwright test resultsDetails
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4589 +/- ##
==========================================
+ Coverage 32.64% 32.68% +0.03%
==========================================
Files 2606 2606
Lines 135676 135726 +50
Branches 30207 30216 +9
==========================================
+ Hits 44297 44361 +64
+ Misses 91379 91365 -14 ☔ View full report in Codecov by Sentry. |
删除行应该可以在 command 里通过多个 mutation 来组合实现 |
Delete rows should be implemented in command using multiple mutations |
这样不太好吧,一个是因为如果改成多个删除行的mutation组合的话 需要从下到上 倒着删除 否则先删除的会影响后面的mutation, 另外就是协同的时候 后面的删除mutation也很难transform,这里还是等后续支持了再fix相关场景吧 |
This is not good. One is because if you change it to a combination of mutations of multiple deletion lines, you need to delete them backwards from bottom to top, otherwise the deletion will affect the subsequent mutation. In addition, when it is coordinated, the subsequent mutations are also difficult to delete mutations. Transform, here we should wait for subsequent support before fixing related scenarios |
d5bf5bc
to
105565d
Compare
|
|
@@ -24,3 +24,8 @@ export interface ISelectionConfig { | |||
export interface ISelectionsConfig { | |||
[subUnitId: string]: ISelectionConfig[]; | |||
} | |||
|
|||
export interface IDiscreteRange { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is impropriate because they are not ranges but row and col numbers. Could you please change it? And this interface is declared twice. Please remove the other one.
8bda973
to
1d36ca2
Compare
1d36ca2
to
acea355
Compare
close https://github.com/dream-num/univer-pro/issues/3978
close https://github.com/dream-num/univer-pro/issues/3980
删除行暂时没处理,因为删除行需要先把这个mutation修改为参数类型为ranges
Pull Request Checklist