Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the filtered content is not included in the clear #4589

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Feb 7, 2025

close https://github.com/dream-num/univer-pro/issues/3978
close https://github.com/dream-num/univer-pro/issues/3980

删除行暂时没处理,因为删除行需要先把这个mutation修改为参数类型为ranges

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot
Copy link

univer-bot bot commented Feb 7, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix: the filtered content is not included in the clear

Title: fix: the filtered content is not included in the clear


close https://github.com/dream-num/univer-pro/issues/3978
close https://github.com/dream-num/univer-pro/issues/3980

删除行暂时没处理,因为删除行需要先把这个mutation修改为参数类型为ranges

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 30 seconds
commit  2c23707
info  For more information, see full report

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 87.20930% with 11 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (a3a55ff) to head (2c23707).

Files with missing lines Patch % Lines
packages/sheets/src/basics/utils.ts 84.31% 8 Missing ⚠️
packages/design/src/components/tree/Tree.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4589      +/-   ##
==========================================
+ Coverage   32.64%   32.68%   +0.03%     
==========================================
  Files        2606     2606              
  Lines      135676   135726      +50     
  Branches    30207    30216       +9     
==========================================
+ Hits        44297    44361      +64     
+ Misses      91379    91365      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 8, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 8, 2025
@wzhudev
Copy link
Member

wzhudev commented Feb 10, 2025

删除行应该可以在 command 里通过多个 mutation 来组合实现

@univer-bot
Copy link

univer-bot bot commented Feb 10, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Delete rows should be implemented in command using multiple mutations

@ybzky
Copy link
Member Author

ybzky commented Feb 17, 2025

删除行应该可以在 command 里通过多个 mutation 来组合实现

这样不太好吧,一个是因为如果改成多个删除行的mutation组合的话 需要从下到上 倒着删除 否则先删除的会影响后面的mutation, 另外就是协同的时候 后面的删除mutation也很难transform,这里还是等后续支持了再fix相关场景吧

@univer-bot
Copy link

univer-bot bot commented Feb 17, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Delete rows should be implemented in command using multiple mutations

This is not good. One is because if you change it to a combination of mutations of multiple deletion lines, you need to delete them backwards from bottom to top, otherwise the deletion will affect the subsequent mutation. In addition, when it is coordinated, the subsequent mutations are also difficult to delete mutations. Transform, here we should wait for subsequent support before fixing related scenarios

@ybzky ybzky force-pushed the fix-clear-with-filter branch from d5bf5bc to 105565d Compare February 17, 2025 03:16
@wzhudev
Copy link
Member

wzhudev commented Feb 19, 2025

删除行应该可以在 command 里通过多个 mutation 来组合实现

这样不太好吧,一个是因为如果改成多个删除行的mutation组合的话 需要从下到上 倒着删除 否则先删除的会影响后面的mutation, 另外就是协同的时候 后面的删除mutation也很难transform,这里还是等后续支持了再fix相关场景吧

  1. 就是要倒着删除
  2. 改为多 ranges 之后, 那你在处理多个两个删除行的 transforms 时就要处理多个 ranges 之间的 transform, 这更难

@univer-bot
Copy link

univer-bot bot commented Feb 19, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Delete rows should be implemented in command using multiple mutations

This is not good. One is because if you change it to a combination of mutations of multiple deletion lines, you need to delete them backwards from bottom to top, otherwise the deletion will affect the subsequent mutation. In addition, the subsequent deletion mutation is also very good when collaboratively. It's difficult to transform, so let's wait for subsequent support before fixing related scenarios.

  1. Just delete it upside down
  2. After changing to multiple ranges, when you process transforms with multiple two delete rows, you have to process transforms between multiple ranges, which is even more difficult.

@@ -24,3 +24,8 @@ export interface ISelectionConfig {
export interface ISelectionsConfig {
[subUnitId: string]: ISelectionConfig[];
}

export interface IDiscreteRange {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is impropriate because they are not ranges but row and col numbers. Could you please change it? And this interface is declared twice. Please remove the other one.

@wzhudev
Copy link
Member

wzhudev commented Feb 19, 2025

Please add a text ellipsis effect here.

image

@ybzky ybzky force-pushed the fix-clear-with-filter branch from 8bda973 to 1d36ca2 Compare February 21, 2025 02:33
@ybzky ybzky force-pushed the fix-clear-with-filter branch from 1d36ca2 to acea355 Compare February 21, 2025 03:09
@ybzky ybzky requested a review from wzhudev February 21, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants