Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix generate facade should execute before hook #4689

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Feb 21, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 21, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  f1da8c7
info  For more information, see full report

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.64%. Comparing base (a3a55ff) to head (f1da8c7).

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-range.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4689      +/-   ##
==========================================
- Coverage   32.64%   32.64%   -0.01%     
==========================================
  Files        2606     2606              
  Lines      135676   135683       +7     
  Branches    30207    30207              
==========================================
  Hits        44297    44297              
- Misses      91379    91386       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant